Redesign Assessment HTML report to have a single subsection having all issues(all categories) #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s expandable to show more info
sanyamsinghal
force-pushed
the
sanyam/html-report
branch
from
3adf2de to
5b982c3
Compare
sanyamsinghal
force-pushed
the
sanyam/html-report
branch
from
5b982c3 to
517ef84
Compare
sanyamsinghal
force-pushed
the
sanyam/html-report
branch
from
455fd45 to
c3603ff
Compare
- due to test validation phase limitation that it needs the same order right now
…ng based on the table headers
makalaaneesh
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
LGTM! i don't know enough html/js to comment :) @priyanshi-yb in case you want to take a look as well, pls do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Changes the html report: removing previous sub sections and adding single subsection
Assessment IssuesThe issues in that list are sorted by category.
For the issues table, we can also sort the rows based on category, type/name, and impact.
Note: final list will be based on each column indepedently sorted, no multi level sorting.
https://yugabyte.atlassian.net/browse/DB-14875
Describe if there are any user-facing changes
Assessment Report html format changes wrt the issues being displayed.
Added buttons in the html report to expand/collapse all the closed/open rows at once.
How was this pull request tested?
Manually.
Once we remove the deprecated fields from
AssessmentReportstruct, we will need to update the expected json reports in the tests.Does your PR have changes that can cause upgrade issues?
Attaching some sample of new HTML reports::